metadata-added-provenance #730

Paurikova2 · 2024-08-13T14:52:14Z

Phases	MP	MM	MB	MR	JM
ETA	0	0	0	0	0
Developing	30	0	0	0	0
Review	0	0	0	0	0
Total	-	-	-	-	-
ETA est.
ETA cust.	-	-	-	-	-

Problem description

After adding, deleting, or editing the metadata of an item, a new record should be created in the metadata as dc.description.provenance.

Paurikova2 · 2024-08-14T04:42:12Z

Problem: the page is loading data from cache?

dspace-api/src/main/java/org/dspace/app/bulkaccesscontrol/BulkAccessControl.java

dspace-server-webapp/src/main/java/org/dspace/app/rest/BundleUploadBitstreamController.java

...in/java/org/dspace/app/rest/repository/patch/operation/DSpaceObjectMetadataAddOperation.java

...java/org/dspace/app/rest/repository/patch/operation/DSpaceObjectMetadataRemoveOperation.java

...ava/org/dspace/app/rest/repository/patch/operation/DSpaceObjectMetadataReplaceOperation.java

...in/java/org/dspace/app/rest/repository/patch/operation/ItemDiscoverableReplaceOperation.java

milanmajchrak · 2024-09-09T07:57:06Z

Checks are not green

dspace-api/src/main/java/org/dspace/core/ProvenanceMessageProvider.java

dspace-api/src/main/java/org/dspace/core/ProvenanceMessageProviderImpl.java

dspace-api/src/main/java/org/dspace/core/ProvenanceService.java

dspace-api/src/main/java/org/dspace/core/ProvenanceServiceImpl.java

dspace-server-webapp/src/main/java/org/dspace/app/rest/BundleUploadBitstreamController.java

...in/java/org/dspace/app/rest/repository/patch/operation/DSpaceObjectMetadataAddOperation.java

...ava/org/dspace/app/rest/repository/patch/operation/DSpaceObjectMetadataReplaceOperation.java

dspace-api/src/main/java/org/dspace/app/bulkaccesscontrol/BulkAccessControl.java

Paurikova2 · 2024-11-28T12:12:30Z

@vidiecan @milanmajchrak
Slack question about metadata: https://dspace-org.slack.com/archives/C3SG47SGY/p1732540863304599

vidiecan · 2024-12-10T07:46:46Z

dspace-api/src/main/java/org/dspace/app/bulkaccesscontrol/BulkAccessControl.java

@@ -552,6 +557,10 @@ private void updateBitstreamPolicies(Bitstream bitstream, Item item, BulkAccessC
     */
    private void removeReadPolicies(DSpaceObject dso, String type) {
        try {
+            String resPoliciesStr = provenanceProvider.removedReadPolicies(context, dso, type);


vidiecan · 2024-12-10T07:47:54Z

dspace-api/src/main/java/org/dspace/core/ProvenanceMessageProvider.java

+    private void loadMessageTemplates() {
+        ObjectMapper mapper = new ObjectMapper();
+        String msg;
+        try (InputStream inputStream = getClass().getResourceAsStream(PROVENANCE_MSG_JSON)) {


vidiecan · 2024-12-10T07:50:18Z

dspace-api/src/main/java/org/dspace/core/ProvenanceMessageProvider.java

+        return msg;
+    }
+
+    public String getResourcePoliciesMessage(List<ResourcePolicy> resPolicies) {


overloading

vidiecan · 2024-12-10T07:50:47Z

dspace-api/src/main/java/org/dspace/core/ProvenanceProvider.java

+import org.dspace.content.service.clarin.ClarinLicenseResourceMappingService;
+
+/**
+ * ProvenanceProviderrest is responsible for creating provenance metadata for items based on the actions performed.


ProvenanceProviderrest

why provider?

done
Created ProvenanceService

vidiecan · 2024-12-10T07:51:48Z

dspace-api/src/main/java/org/dspace/core/ProvenanceProvider.java

+                .collect(Collectors.joining(";"));
+    }
+
+    private Item getItem(Context context, Bitstream bitstream) throws SQLException {


Renamed to findItemByBitstream.

This method call a clarinItemService.findByBitstreamUUID(...) method and process the response - log if there is no Item,..

vidiecan · 2024-12-10T07:53:51Z

dspace-server-webapp/src/main/java/org/dspace/app/rest/BundleUploadBitstreamController.java

        try {
            fileInputStream = uploadfile.getInputStream();
        } catch (IOException e) {
            log.error("Something went wrong when trying to read the inputstream from the given file in the request",
                      e);
            throw new UnprocessableEntityException("The InputStream from the file couldn't be read", e);
        }
+        try {
+            provenanceProvider.uploadBitstream(context, bundle);


vidiecan · 2024-12-10T07:55:19Z

dspace-server-webapp/src/main/java/org/dspace/app/rest/MappedCollectionRestController.java

@@ -104,6 +107,7 @@ public void createCollectionToItemRelation(@PathVariable UUID uuid,

                collectionService.addItem(context, collectionToMapTo, item);
                collectionService.update(context, collectionToMapTo);
+                provenanceProvider.mappedItem(context, item, collectionToMapTo);


vidiecan · 2024-12-10T07:55:50Z

...p/src/main/java/org/dspace/app/rest/repository/patch/operation/BitstreamRemoveOperation.java

        try {
+            provenanceProvider.deleteBitstream(context, bitstreamToDelete);
            bitstreamService.delete(context, bitstreamToDelete);


vidiecan · 2024-12-10T07:56:07Z

...in/java/org/dspace/app/rest/repository/patch/operation/DSpaceObjectMetadataAddOperation.java

        } catch (SQLException e) {
-            throw new DSpaceBadRequestException("SQLException in DspaceObjectMetadataAddOperation.add trying to add " +
-                    "metadata to dso.", e);
+            msg = "SQLException in DspaceObjectMetadataAddOperation.add trying to add " +


vidiecan · 2024-12-10T07:56:31Z

...java/org/dspace/app/rest/repository/patch/operation/DSpaceObjectMetadataRemoveOperation.java

        try {
            if (index == null) {
+                provenanceProvider.removeMetadata(context, dso, metadataField);


dspace-api/src/main/java/org/dspace/app/bulkaccesscontrol/BulkAccessControl.java

dspace-api/src/main/java/org/dspace/core/ProvenanceProvider.java

…g policy

…rpose.

… when calling provenance methods.

…be used as Spring Service.

added provenance metadata for update, remove and add

380fb45

Paurikova2 linked an issue Aug 13, 2024 that may be closed by this pull request

Metadata edits and provenance #643

Open

checkstyle violations

ffe630a

Paurikova2 added 16 commits August 14, 2024 09:30

added provenance metadata for update and remove bitstream

46335a1

item test json added metadata provenance

96158a5

removed unwanted lines

9d6097f

control provenance only by tests of item

a0c500a

update and remove license

c79c000

provenance access control and upload bitstream

c55d418

provenance move item to different collection

499aac4

provenance make item non-discoverable

9c361d9

checkstyle violations and test failures

9f94913

make code more readable

2a0d919

provenance for mapped collection

1922907

grammer check

d9dd689

don't write provenance for bitstream without item

5cddf35

move addProvenance to parent class

4a6072a

refactoring

e468c90

checkstyle violations and test failures

9910c90

milanmajchrak requested changes Sep 9, 2024

View reviewed changes

removed unnecessary variables, added logs and checkstyle

18607a5

Paurikova2 requested a review from milanmajchrak September 10, 2024 07:27

milanmajchrak previously approved these changes Sep 10, 2024

View reviewed changes

milanmajchrak requested a review from vidiecan September 10, 2024 07:56

Paurikova2 added 3 commits September 25, 2024 08:13

separated class for provenance

aae82cc

create class for provenance management

0b3c0d7

added metadata item and bitstream tests

64d84a1

Paurikova2 dismissed milanmajchrak’s stale review via 64d84a1 October 1, 2024 09:58

milanmajchrak requested changes Oct 8, 2024

View reviewed changes

log exception, replace ! by non conds, added doc comments

2fdc96e

milanmajchrak approved these changes Oct 16, 2024

View reviewed changes

milanmajchrak requested changes Oct 16, 2024

View reviewed changes

...ava/org/dspace/app/rest/repository/patch/operation/DSpaceObjectMetadataReplaceOperation.java Outdated Show resolved Hide resolved

added logs for replacing mtd

b026ca0

Paurikova2 requested a review from milanmajchrak October 17, 2024 10:54

milanmajchrak previously approved these changes Oct 17, 2024

View reviewed changes

milanmajchrak requested a review from vidiecan October 17, 2024 10:55

vidiecan requested changes Oct 17, 2024

View reviewed changes

milanmajchrak requested a review from vidiecan October 17, 2024 13:50

Paurikova2 self-assigned this Nov 14, 2024

removed unused services

64d7eae

Paurikova2 dismissed milanmajchrak’s stale review via 64d7eae November 20, 2024 09:30

Paurikova2 added 3 commits November 22, 2024 11:44

make object from provenance service

49cae22

removed interface prom provenance msg provider

eb2315e

checkstyle

876a7f2

Paurikova2 requested a review from milanmajchrak November 22, 2024 12:55

vidiecan requested changes Dec 10, 2024

View reviewed changes

milanmajchrak requested changes Dec 11, 2024

View reviewed changes

milanmajchrak added 9 commits December 12, 2024 14:38

Refactored method removeReadPolicies - add provenance after removin…

130d78f

…g policy

The message templates are loaded from the Enum instead of json file.

419aff3

The getMessage methods was overloaded.

a0abf72

Renamed getItem to findItemByBitstream to clarify the method's pu…

a1324ce

…rpose.

Do not throw exception when adding to provenance

8ff24e0

The exceptions are caught in the ProvenanceProvider and changed order…

51302fa

… when calling provenance methods.

Renamed ProvenanceProvider to ProvenanceService and refactored it to …

46ab18c

…be used as Spring Service.

The ProvenanceService wasn't initialized in the BundleAccessControl

5f63dcd

Removal of unwanted changes

fb82e94

milanmajchrak requested a review from vidiecan December 16, 2024 08:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

metadata-added-provenance #730

metadata-added-provenance #730

Paurikova2 commented Aug 13, 2024 •

edited

Loading

Paurikova2 commented Aug 14, 2024

milanmajchrak commented Sep 9, 2024

Paurikova2 commented Nov 28, 2024

vidiecan Dec 10, 2024

vidiecan Dec 10, 2024

milanmajchrak Dec 12, 2024

vidiecan Dec 10, 2024

milanmajchrak Dec 12, 2024

vidiecan Dec 10, 2024

milanmajchrak Dec 13, 2024

vidiecan Dec 10, 2024

milanmajchrak Dec 16, 2024

vidiecan Dec 10, 2024

milanmajchrak Dec 13, 2024

vidiecan Dec 10, 2024

milanmajchrak Dec 13, 2024

vidiecan Dec 10, 2024

milanmajchrak Dec 13, 2024

vidiecan Dec 10, 2024

milanmajchrak Dec 13, 2024

vidiecan Dec 10, 2024

milanmajchrak Dec 13, 2024

vidiecan Dec 10, 2024

milanmajchrak Dec 13, 2024

metadata-added-provenance #730

Are you sure you want to change the base?

metadata-added-provenance #730

Conversation

Paurikova2 commented Aug 13, 2024 • edited Loading

Problem description

Paurikova2 commented Aug 14, 2024

milanmajchrak commented Sep 9, 2024

Paurikova2 commented Nov 28, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Paurikova2 commented Aug 13, 2024 •

edited

Loading